Custom Background Enhancements Part 1 #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will need to make some changes to reader/writer and loading logic to be able to parse which region it's in and load the correct bg
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,7 +1,9 @@ | |||
| using CollapseLauncher.CustomControls; | |||
| using CollapseLauncher.Extension; | |||
| using CollapseLauncher.FileDialogCOM; | |||
Check warning
Code scanning / QDNET
Redundant using directive Warning
| using CollapseLauncher.Helper; | ||
| using CollapseLauncher.Helper.Animation; | ||
| using CollapseLauncher.Helper.Image; |
Check warning
Code scanning / QDNET
Redundant using directive Warning
| @@ -9,6 +9,7 @@ | |||
| using CollapseLauncher.Helper; | |||
| using CollapseLauncher.Helper.Animation; | |||
| using CollapseLauncher.Helper.Image; | |||
| using CollapseLauncher.Helper.Background; | |||
Check warning
Code scanning / QDNET
Redundant using directive Warning
...eLauncher/Classes/GameManagement/GameSettings/Universal/RegistryClass/CollapseMiscSetting.cs
Fixed
Show fixed
Hide fixed
| @@ -18,6 +19,7 @@ | |||
| using CommunityToolkit.WinUI.Animations; | |||
| using H.NotifyIcon; | |||
| using Hi3Helper; | |||
| using Hi3Helper.Data; | |||
Check warning
Code scanning / QDNET
Redundant using directive Warning
CollapseLauncher/Classes/GameManagement/GameSettings/StarRail/RegistryClass/Model.cs
Fixed
Show fixed
Hide fixed
CollapseLauncher/XAMLs/MainApp/Pages/GameSettingsPages/StarRailGameSettingsPage.xaml.cs
Fixed
Show fixed
Hide fixed
This to prevents NRE when saving settings that is not previously fetched, in the case of HSR and GI.
and other tidbits
|
All good, signed by me and neon in vc proof(tm) |
bagusnl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goal
The initial goal of this PR is to bring the background changing functionality into the Quick Settings menu for easier access. This works exactly in the same way as the one in Game Settings does.
The end-goal of this change is to eventually remove the button from the Application Settings page and have it reside exclusively in Quick Settings, as background assets will be managed on a per-game and per-region basis (hence "Part 1").
PS. This feature does not require global App custom background to be enabled. Simply go to the "Additional Button" in home page (bottom right) and change the toggle and background there.
PR Status :
TODO
boolvalue is not applied toToggleSwitchfor both Custom Args & Region Background togglesButtonandStackPanelText properties